[Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)
Thiago Milczarek Sayao
tsayao at openjdk.java.net
Tue Mar 31 20:47:55 UTC 2020
On Thu, 26 Mar 2020 11:21:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> I think it's better to split the flags between CFLAGS and CPPFLAGS (as is done in OpenJDK). The
>> `-Werror=implicit-function-declaration` is extremely useful for C files, and we don't want to risk that this somehow
>> got lost. If we use CFLAGS and CPPFLAGS, we can pass the latter as CXXFLAGS to cmake, so that should be fairly easy.
>
> I took a look yesterday and came to the same conclusion that what we really want are separate C and C++ flags. For now,
> the only difference would be the presence or absence of `-Werror=implicit-function-declaration`, but it would allow for
> other differences in the future if needed.
Please, let me know if this is the desired way to do it. If not, I will rework it. Thanks.
-------------
PR: https://git.openjdk.java.net/jfx/pull/150
More information about the openjfx-dev
mailing list