RFR: 8241999: ChoiceBox: incorrect toggle selected for uncontained

[Ajit Ghaisas]

On Tue, 28 Apr 2020 20:44:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The issue is that the toggles is not reliably unselected if an uncontained value is set.
>> 
>> The root is ChoiceBoxSelectionModel which doesn't update the index on selecting an uncontained item, in particular it
>> fails to keep the invariant:
>>      assertEquals(getItems().indexOf(selectedItem), selectedIndex);
>> 
>> The fix here is to override select(item) to guarantee the assert.
>> 
>> Added/removed ignore from tests that failed before and pass after the fix. All other tests are passing before and after.
>
> @aghaisas can you review this? It looks pretty simple so one reviewer should be enough, unless you spot something where
> you want a second pair of eyes.

@kevinrushforth, I agree on single reviewer being enough for this change.
The fix looks good to me.

-------------

PR: https://git.openjdk.java.net/jfx/pull/200