RFR: 8244297: memory leak test utility

Florian Kirmaier fkirmaier at openjdk.java.net
Tue May 5 10:41:04 UTC 2020


On Mon, 4 May 2020 14:24:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> It's based on the discussion of my previous PR: https://github.com/openjdk/jfx/pull/71
>> 
>> I Added test utility class copied from JMemoryBuddy and used it to simplify 4 of the existing unit tests.
>> 
>> It's a direct copy of my project [JMemoryBuddy](https://github.com/Sandec/JMemoryBuddy) without any changes.
>> I'm also using it in most of the projects I'm involved with and in my experience, the tests with this Library are very
>> stable. I can't remember wrong test results. Sometimes the memory behaviour of some libraries itself is not stable but
>> the tests with JMemoryBuddy are basically always correct.
>
> I'll put this on my queue to review and test it. I left some high-level comments below.

I would suggest making everything configurable in the original library which will be suggested here to be changed.
I will now add the possibility to make the creation of the heapDump configurable, and also the createGarbage method.
If something should behave differently by default, then I will just adjust the default values for this copy of the
library.

I will improve the documentation in the original Library. How should I add the documentation to the JavaFX project?
Ideally, I would just reference somewhere to the documentation of the original library. How/Where should I do that?

-------------

PR: https://git.openjdk.java.net/jfx/pull/204


More information about the openjfx-dev mailing list