[Rev 01] RFR: 8244110: NPE in MenuButtonSkinBase change listener

Jeanette Winzenburg fastegal at openjdk.java.net
Tue May 5 13:55:17 UTC 2020


On Tue, 5 May 2020 12:38:26 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make ChangeListener Final
>
> Looks good. I confirm that the original system test and the new controls unit test both fail without the fix and now
> pass with the fix.

not sure if it is appropriate to approve this? we talked so much about it, that it feels like self-approval :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/205


More information about the openjfx-dev mailing list