[Integrated] RFR: 8244110: NPE in MenuButtonSkinBase change listener

[Ajit Ghaisas]

On Mon, 4 May 2020 09:07:53 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244110
> 
> Root Cause :
> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added code to remove accelerators from a scene
> in Scene property listener of MenuButtonSkinBase. That fix uses getSkinnable() in listener. It turned out that it can
> be null as found out by failing system test.  Fix :
> As pointed out by @kleopatra on the JBS, getSkinnable() should never be null for a valid skin. Hence, the correct fix
> is to remove listener cleanly in dispose method. See JBS comments for more info. This also addresses
> [JDK-8244081](https://bugs.openjdk.java.net/browse/JDK-8244081).  Testing :
> 1) Failing system test - passes after the fix
> 2) 3 unit tests which used to log NPE message silently and pass have been made to fail without this fix - these tests
> passes after the fix
> Special Thanks to @kleopatra for most of the test digging and fix guidance.

This pull request has now been integrated.

Changeset: 39d9c3b7
Author:    Ajit Ghaisas <aghaisas at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/39d9c3b7
Stats:     43 lines in 2 files changed: 1 ins; 38 del; 4 mod

8244110: NPE in MenuButtonSkinBase change listener

Co-authored-by: Jeanette Winzenburg <fastegal at openjdk.org>
Reviewed-by: kcr, fastegal

-------------

PR: https://git.openjdk.java.net/jfx/pull/205