[Rev 01] RFR: 8244112: Skin implementations: must not violate contract of dispose
Jeanette Winzenburg
fastegal at openjdk.java.net
Wed May 6 11:46:27 UTC 2020
> some skins have not been guarding themselves against multiple calls to dispose (see issue for details)
>
> Fixed by backing out off dispose if skinnable is null. Added test (parameterized in control class) for all controls in
> the controls package. Those that failed for the misbehaving skins before are passing after the fix.
Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
cleanup
- corrected incorrect bug id in commented
- removed unrelated test change from TextAreaTest
- updated copyright year
published and seeing oversights ;)
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/209/files
- new: https://git.openjdk.java.net/jfx/pull/209/files/cebeba51..fe76204d
Webrevs:
- full: https://webrevs.openjdk.java.net/jfx/209/webrev.01
- incr: https://webrevs.openjdk.java.net/jfx/209/webrev.00-01
Stats: 27 lines in 5 files changed: 0 ins; 23 del; 4 mod
Patch: https://git.openjdk.java.net/jfx/pull/209.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/209/head:pull/209
PR: https://git.openjdk.java.net/jfx/pull/209
More information about the openjfx-dev
mailing list