RFR: 8242001: ChoiceBox: must update value on setting SelectionModel, part2

Kevin Rushforth kcr at openjdk.java.net
Wed May 6 23:21:36 UTC 2020


On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The issue is that ChoiceBox didn't sync its value to the replaced SelectionModel's selectedItem if the item is null.
> 
> Fixed by removing the constraint from selectionModel property.
> 
> Added tests that failed before and passed after the fix. Note that I also changed a test method in ChoiceBoxTest with
> an incorrect test assumption (which passed for the incorrect implementation).

@aghaisas I presume you will review this (as with the earlier fix it probably doesn't need two reviewers)?

-------------

PR: https://git.openjdk.java.net/jfx/pull/207


More information about the openjfx-dev mailing list