[Integrated] RFR: 8242001: ChoiceBox: must update value on setting SelectionModel, part2
Jeanette Winzenburg
fastegal at openjdk.java.net
Fri May 8 12:28:04 UTC 2020
On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
> The issue is that ChoiceBox didn't sync its value to the replaced SelectionModel's selectedItem if the item is null.
>
> Fixed by removing the constraint from selectionModel property.
>
> Added tests that failed before and passed after the fix. Note that I also changed a test method in ChoiceBoxTest with
> an incorrect test assumption (which passed for the incorrect implementation).
This pull request has now been integrated.
Changeset: 4ec163df
Author: Jeanette Winzenburg <fastegal at openjdk.org>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL: https://git.openjdk.java.net/jfx/commit/4ec163df
Stats: 46 lines in 3 files changed: 1 ins; 42 del; 3 mod
8242001: ChoiceBox: must update value on setting SelectionModel, part2
Reviewed-by: aghaisas
-------------
PR: https://git.openjdk.java.net/jfx/pull/207
More information about the openjfx-dev
mailing list