RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

[Kevin Rushforth]

On Fri, 1 May 2020 15:22:39 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java line 994:
>> 
>>> 993:         private void moveTab(int moveToIndex, TabHeaderSkin tabHeaderSkin) {
>>> 994:             if (moveToIndex != headersRegion.getChildren().indexOf(tabHeaderSkin)) {
>>> 995:                 headersRegion.getChildren().remove(tabHeaderSkin);
>> 
>> Unless I am missing something, this check seems unrelated to the bug.
>
> Yes Kevin, this is not required for fix. In some scenarios the tabHeader gets placed at correct index due to the
> addition of new headers, so this movement becomes redundant.

In that case, this change is fine.

-------------

PR: https://git.openjdk.java.net/jfx/pull/201