RFR: 8244212: Optionally download media and webkit libraries from latest openjfx EA build

[Jesper Skov]

On Thu, 30 Apr 2020 20:10:19 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I have tested on Linux (Fedora 31) only.
>> It works as intended (with one test failure due to 15-ea+4 being too old now).
>> 
>> UPDATE_STUB_CACHE suggests there is some magic available to help manage the stub cache.
>> But as I could not find anything about it, that section in the documentation may need some love.
>
> build.gradle line 1259:
> 
>> 1258: def String jdkStubRuntime = cygpath("$JDK_HOME")
>> 1259: def String openjfxStubRuntime = cygpath("$projectDir") + "/build/openjfxStub"
>> 1260:
> 
> I might suggest `buildSrc/build/openjfxStub` so it doesn't get removed by `gradle clean`.

Neat. I did not know that was a thing. Done.

> build.gradle line 3391:
> 
>> 3390:         doFirst {
>> 3391:             if (IS_STUB_RUNTIME_OPENJFX) {
>> 3392:                 println "********************************************************"
> 
> Perhaps this should be inside the `if (!IS_COMPILE_WEBKIT)` ?

I assume you mean like this:
`
            if (!IS_COMPILE_WEBKIT) {
                if (IS_STUB_RUNTIME_OPENJFX) {
                   println ...
                } else {
                   println ...
		}
            }
`
I do not like the additional indentation level, so I have left it as is.

The semantics should be the same, as long as no one use stubs *and* compile webkit.
Which should maybe rather cause a build exception?

But it is not something I feel strongly for, so I am happy to change it :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/202