[Rev 02] RFR: 8218973: SVG with masking is not rendering image with mask effect

Bhawesh Choudhary github.com+4208131+bhaweshkc at openjdk.java.net
Mon May 11 05:32:17 UTC 2020


On Fri, 8 May 2020 23:25:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved Printing drawing path to non MaskTextureGraphics interface
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java line 549:
> 
>> 548:                             Texture.WrapMode.CLAMP_NOT_NEEDED);
>> 549:                     RTTexture maskRtTexture = g.getResourceFactory().createRTTexture(nativeMaskImage.getWidth(),
>> 550:                             nativeMaskImage.getHeight(), Texture.WrapMode.CLAMP_NOT_NEEDED);
> 
> Why do you need to create a second RTT here? I would have thought you could use the mask texture directly (you may need
> to scale the image in order to do that).

main problem with not using second RTTexture is the interface MaskTextureGraphics, which accept RTTexture only. also it
difficult to add new API taking Texture instead of RTTexture given that SW Pipeline and J2D pipeline has direct
dependency on RTTexture interface.

-------------

PR: https://git.openjdk.java.net/jfx/pull/213


More information about the openjfx-dev mailing list