[Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.

Tom Schindl tschindl at openjdk.java.net
Tue May 12 12:05:50 UTC 2020


On Tue, 28 Apr 2020 22:36:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Tom Schindl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
>>   
>>   Fix whitespace errors
>
> Looks good to me. I verified that the new test fails without your fix and passes with your fix.
> 
> In case anyone else is looking at this and wants to run the test, it isn't enabled by default, so you need to run it
> like this:
> gradle -PUNSTABLE_TEST=true -PFULL_TEST=true -PUSE_ROBOT=true \
>     :systemTests:test --tests test.robot.com.sun.glass.ui.monocle.RobotTest

@kevinrushforth is there anything left todo or did you simply forget to merge it?

-------------

PR: https://git.openjdk.java.net/jfx/pull/170


More information about the openjfx-dev mailing list