[Integrated] RFR: 8244735: Error on iOS passing keys with unicode values greater than 255

Jose Pereda jpereda at openjdk.java.net
Tue May 12 12:16:13 UTC 2020


On Mon, 11 May 2020 12:50:48 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

> With this PR, we pass directly the 16-bit unsigned short for a character (unicode value) to the Java layer, avoiding
> the cast with the C++ 8-bit char, that fails for non-ascii characters like euro (€) or quote (").
> We also avoid the mapping between iOS keys and JavaFX `KeyCode`, except for `ENTER` and `BACK_SPACE`, as the mapping
> for some keys was wrong, like for "%", with ascii value 0x25, that was mapped to KeyCode.LEFT.
> Finally, the iOS keyboard is set to `UIKeyboardTypeASCIICapable`, to prevent the display of the emoji keyboard, that
> can't be currently processed.

This pull request has now been integrated.

Changeset: b14e0858
Author:    Jose Pereda <jpereda at openjdk.org>
Committer: Johan Vos <jvos at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/b14e0858
Stats:     39 lines in 6 files changed: 7 ins; 20 del; 12 mod

8244735: Error on iOS passing keys with unicode values greater than 255

Reviewed-by: jvos

-------------

PR: https://git.openjdk.java.net/jfx/pull/217


More information about the openjfx-dev mailing list