[Rev 01] RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts
Rony G.Flatscher
github.com+60214806+ronyfla at openjdk.java.net
Wed May 13 08:46:11 UTC 2020
> This WIP adds the ability for a fallback in case compilation of scripts fails, in which case a warning gets issued
> about this fact and evaluation of the script will be done without compilation. Because of the fallback scripts get
> compiled with this version by default. It extends PR 187 <https://github.com/openjdk/jfx/pull/187>. To further ease
> spotting scripts that cause a ScriptException a message in the form of "filename: caused ScriptException" gets added to
> the exception handling in either of the three locations: an error message, a stack trace or a wrap-up into a
> RuntimeException (having three different kinds of reporting ScriptExceptions may be questioned, however none of these
> tear down the FXML GUI).
Rony G. Flatscher has updated the pull request incrementally with one additional commit since the last revision:
Reword the compile processing instructions (replace 'Hint' with 'Note:', adjust text to context), remove spurious empty
line in script example code.
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/192/files
- new: https://git.openjdk.java.net/jfx/pull/192/files/44b0f9f8..59a16c9f
Webrevs:
- full: https://webrevs.openjdk.java.net/jfx/192/webrev.01
- incr: https://webrevs.openjdk.java.net/jfx/192/webrev.00-01
Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
Patch: https://git.openjdk.java.net/jfx/pull/192.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/192/head:pull/192
PR: https://git.openjdk.java.net/jfx/pull/192
More information about the openjfx-dev
mailing list