[Rev 01] RFR: 8244647: Wrong first layout pass of Scrollbar controls on touch supported devices

Jose Pereda jpereda at openjdk.java.net
Wed May 13 09:38:24 UTC 2020


On Wed, 13 May 2020 09:14:02 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply code formatting
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 2449:
> 
>> 2448:                     double prefHeight = hbar.prefHeight(viewportBreadth);
>> 2449:                     hbar.resizeRelocate(0, viewportLength-prefHeight,
>> 2450:                             viewportBreadth, prefHeight);
> 
> Minor : Code formatting convention: Add spaces around '-' at 4 places in your changes.
> It was not followed in earlier version, but let's correct it while touching these lines.

Yes, makes sense, I thought about doing it while removing the unnecessary parenthesis but didn't want to be too
intrusive. Done.

-------------

PR: https://git.openjdk.java.net/jfx/pull/215


More information about the openjfx-dev mailing list