RFR: 8242523: Update the animation and clip envelope classes
Ambarish Rapte
arapte at openjdk.java.net
Thu May 14 05:37:29 UTC 2020
On Wed, 13 May 2020 00:38:03 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/MultiLoopClipEnvelope.java line 48:
>>
>>> 47:
>>> 48: protected boolean autoReverse() {
>>> 49: return autoReverse;
>>
>> I would suggest the name to be `isAutoReverese`
>
> That would be the usual naming convention, yes, but I find that this can be more fluent to read. Perhaps I'm
> influenced by the upcoming `record`s feature. Can change.
Yes, please change. Animation.java also has `isAutoReverese` method, It would be good to be uniform.
-------------
PR: https://git.openjdk.java.net/jfx/pull/196
More information about the openjfx-dev
mailing list