[Rev 01] RFR: 8244112: Skin implementations: must not violate contract of dispose

[Jeanette Winzenburg]

On Thu, 14 May 2020 04:44:38 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> good catch :)
>> 
>> Hmm .. thinking aloud:
>> 
>> - all in web is a bit very different as a small layer on top of the webEngine, usually off my radar
>> - the skinnable windows are no controls
>> 
>> so the easy way out - which I would tend take :) - is to narrow the issue to include only controls in controls. What do
>> you think?
>
> Agree that HTMLEditorSkin is a web module. let's keep it off radar :)
> 
> TooltipSkin and ContextMenuSkin implement Skin and override the dispose() method. I think these Skins should also
> behave similar to other and can be included here in test. and also should consider them under cleanup issue
> [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364). Both the dispose() seem safe from NPE.

okay, added a separate test for ContextMenu/Tooltip (they don't fit into the binch test here :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/209