[Rev 03] RFR: 8244112: Skin implementations: must not violate contract of dispose
Jeanette Winzenburg
fastegal at openjdk.java.net
Thu May 14 10:11:17 UTC 2020
On Thu, 14 May 2020 09:42:21 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added test for ContextMenu/Tooltip skin as requested in review
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinPopupContractTest.java line 50:
>
>> 49: public void testContextMenuSkinDispose() {
>> 50: ContextMenu tooltip = new ContextMenu();
>> 51: tooltip.setSkin(new ContextMenuSkin(tooltip));
>
> minor: `tooltip` should be renamed as `contextMenu`.
haha .. spotted the c&p :)) Done and thanks!
-------------
PR: https://git.openjdk.java.net/jfx/pull/209
More information about the openjfx-dev
mailing list