[Rev 04] RFR: 8244112: Skin implementations: must not violate contract of dispose

Ambarish Rapte arapte at openjdk.java.net
Thu May 14 12:09:11 UTC 2020


On Thu, 14 May 2020 10:11:16 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> some skins have not been guarding themselves against multiple calls to dispose (see issue for details)
>> 
>> Fixed by backing out off dispose if skinnable is null. Added test (parameterized in control class) for all controls in
>> the controls package. Those that failed for the misbehaving skins before are passing after the fix.
>
> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   renamed misnamed local field

Looks good to me...

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/209


More information about the openjfx-dev mailing list