[Integrated] RFR: 8244112: Skin implementations: must not violate contract of dispose

Jeanette Winzenburg fastegal at openjdk.java.net
Fri May 15 04:50:24 UTC 2020


On Wed, 6 May 2020 11:16:50 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> some skins have not been guarding themselves against multiple calls to dispose (see issue for details)
> 
> Fixed by backing out off dispose if skinnable is null. Added test (parameterized in control class) for all controls in
> the controls package. Those that failed for the misbehaving skins before are passing after the fix.

This pull request has now been integrated.

Changeset: bb243224
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/bb243224
Stats:     278 lines in 7 files changed: 1 ins; 273 del; 4 mod

8244112: Skin implementations: must not violate contract of dispose

Reviewed-by: aghaisas, arapte

-------------

PR: https://git.openjdk.java.net/jfx/pull/209


More information about the openjfx-dev mailing list