[Rev 02] RFR: 8218973: SVG with masking is not rendering image with mask effect

Arun Joseph ajoseph at openjdk.java.net
Mon May 18 05:15:18 UTC 2020


On Sun, 10 May 2020 20:49:07 GMT, Bhawesh Choudhary <github.com+4208131+bhaweshkc at openjdk.org> wrote:

>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add implementation of function clipToImageBuffer()
>> in GraphicsContextJava.cpp and send clip image to WCGraphicsPrismContext.java  While rendering in
>> WCGraphicsPrismContext.java if image clip mask is available, use it for rendering using MaskTextureGraphics interface
>> otherwise use usual way of rendering.
>
> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved Printing drawing path to non MaskTextureGraphics interface

modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java line 560:

> 559:                     } else {
> 560:                         Screen screen = g.getAssociatedScreen();
> 561:                         FilterContext filterContext;

This logic is already present in getFilterContext(). You can call the function instead.

-------------

PR: https://git.openjdk.java.net/jfx/pull/213


More information about the openjfx-dev mailing list