[Rev 01] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

Abhinay Agarwal github.com+3197675+abhinayagarwal at openjdk.java.net
Tue May 19 08:10:40 UTC 2020


> In Android, TextInputControls (TextField and TextArea) are responsible for showing and hiding software keyboard.
> Currently, a focus listener is attached to these controls and is used to toggle the visibility of keyboard. This
> condition fails in cases where the control already has focus but the keyboard is not visible.  Ideally, the keyboard
> should be shown again when the user taps on the TextInputControl.
> This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows the keyboard  if the TextInput control is
> both editable and focused.

Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision:

  Remove listeners in dispose method

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/219/files
  - new: https://git.openjdk.java.net/jfx/pull/219/files/6f56d48d..9b7d54f4

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/219/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/219/webrev.00-01

  Stats: 93 lines in 2 files changed: 63 ins; 0 del; 30 mod
  Patch: https://git.openjdk.java.net/jfx/pull/219.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/219/head:pull/219

PR: https://git.openjdk.java.net/jfx/pull/219


More information about the openjfx-dev mailing list