RFR: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

Kevin Rushforth kcr at openjdk.java.net
Tue May 19 11:41:13 UTC 2020


On Tue, 19 May 2020 10:29:12 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Issue : https://bugs.openjdk.java.net/browse/JDK-8245181
>> 
>> Root cause : The exception just gets logged and does not result in test failure.
>> 
>> Fix : Added the mechanism to catch and handle UncaughtException. Test test_rt35039_resetRootChildren fails with this
>> mechanism. Fixed the test failure by adding the check in TreeTableView class. In addition, unrelated to above fix, I
>> have removed System.out.printlns that were causing log pollution.
>
> I completed the work with an incorrect branch name. I will continue using this branch only for this fix.

So the exception was pointing out an actual bug in the implementation, but it wasn't causing a test failure. Even
though this isn't a test-only bug, it looks simple enough that a single reviewer should suffice.

-------------

PR: https://git.openjdk.java.net/jfx/pull/224


More information about the openjfx-dev mailing list