RFR: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
Kevin Rushforth
kcr at openjdk.java.net
Thu May 28 14:46:37 UTC 2020
On Thu, 28 May 2020 08:45:36 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:
> Issue: Snapshot taken before webpage is rendered
>
> Fix: Use stateProperty and sleep to wait for the page to finish rendering
I tested it on my machine and it is running reliably for me now. I have a couple suggestions below.
tests/system/src/test/java/test/javafx/scene/web/SVGTest.java line 116:
> 115: Util.runAndWait(() -> {
> 116: webView.getEngine().getLoadWorker().stateProperty().
> 117: addListener((observable, oldValue, newValue) -> {
This should go after the `assertNotNull`
tests/system/src/test/java/test/javafx/scene/web/SVGTest.java line 126:
> 125:
> 126: webView.focusedProperty().
> 127: addListener((observable, oldValue, newValue) -> {
The listener should probably be installed before the content is loaded.
-------------
PR: https://git.openjdk.java.net/jfx/pull/240
More information about the openjfx-dev
mailing list