RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

Ajit Ghaisas aghaisas at openjdk.java.net
Fri May 29 05:37:21 UTC 2020


On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Both skins have similar misbehavior when switching skins
> 
> - memory leak due to a manually added but not removed change listener
> - NPE when modifying items after skin switch due to a not removed listener to the control's items
> 
> Fixed in both (for details see the issue). Added SkinCleanupTest for simple testing of per-control side-effects,
> removed both skins from memory test exclusion list: failing before and passing after fix.

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/238


More information about the openjfx-dev mailing list