[Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

[Johan Vos]

On Tue, 19 May 2020 10:19:42 GMT, Abhinay Agarwal <github.com+3197675+abhinayagarwal at openjdk.org> wrote:

>> In Android, TextInputControls (TextField and TextArea) are responsible for showing and hiding software keyboard.
>> Currently, a focus listener is attached to these controls and is used to toggle the visibility of keyboard. This
>> condition fails in cases where the control already has focus but the keyboard is not visible.  Ideally, the keyboard
>> should be shown again when the user taps on the TextInputControl.
>> This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows the keyboard  if the TextInput control is
>> both editable and focused.
>
> Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Skin implementation must maintain the contract of dispose

Looks good.
A test strategy for Android is a good idea for a follow-up issue.

-------------

Marked as reviewed by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/219