[Integrated] RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

[Jeanette Winzenburg]

On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Both skins have similar misbehavior when switching skins
> 
> - memory leak due to a manually added but not removed change listener
> - NPE when modifying items after skin switch due to a not removed listener to the control's items
> 
> Fixed in both (for details see the issue). Added SkinCleanupTest for simple testing of per-control side-effects,
> removed both skins from memory test exclusion list: failing before and passing after fix.

This pull request has now been integrated.

Changeset: 1ab653cb
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/1ab653cb
Stats:     158 lines in 4 files changed: 3 ins; 150 del; 5 mod

8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

Reviewed-by: aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/238