RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

Jose Pereda jpereda at openjdk.java.net
Wed Nov 4 16:08:09 UTC 2020


On Wed, 4 Nov 2020 11:12:06 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> Allow the EGL functionality in monocle to leverage EGL-based systems. The low-level specific details about how the EGL calls should be constructed are left out, and a native interface (egl_ext.h) is created that can be mapped to any low-level system.
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   process reviewer comments

modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java line 73:

> 71:     }
> 72: 
> 73:     public boolean swapBuffers() {

Add @Override annotation

modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java line 75:

> 73:     public boolean swapBuffers() {
> 74:         boolean result = false;
> 75:         synchronized(NativeScreen.framebufferSwapLock) {

Add white space after `synchronized`

-------------

PR: https://git.openjdk.java.net/jfx/pull/343


More information about the openjfx-dev mailing list