RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

[Johan Vos]

On Thu, 5 Nov 2020 02:45:00 GMT, John Neffenger <github.com+1413266+jgneff at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add one more @override to process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java line 46:
> 
>> 44:      */
>> 45:     EGLAcceleratedScreen(int[] attributes) throws GLException {
>> 46:         eglWindowHandle = platformGetNativeWindow();
> 
> My IDE flags this line with "Overridable method call in constructor" (Item 19 in Bloch's *Effective Java Third Edition*): "the overriding method in the subclass will get invoked before the subclass constructor has run."

We can make this private, but that would give a wrong sense of security, as the native method can still be implemented in different ways.
@kevinrushforth Do we have the policy of not using overridable method calls in constructors?

> modules/javafx.graphics/src/main/native-glass/monocle/egl/egl_ext.h line 29:
> 
>> 27: #include <jni.h>
>> 28: extern long getNativeWindowHandle(const char *v);
>> 29: extern long getEGLDisplayHandle();
> 
> Rename to `getEglDisplayHandle` like all the others?

fixed.

> modules/javafx.graphics/src/main/native-glass/monocle/egl/egl_ext.h line 32:
> 
>> 30: extern jboolean doEglInitialize(void* handle);
>> 31: extern jboolean doEglBindApi(int api);
>> 32: extern jlong doEglChooseConfig (long eglDisplay, int* attribs);
> 
> This function definition and the three that follow have a space before the left parenthesis.

fixed

-------------

PR: https://git.openjdk.java.net/jfx/pull/343