RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off
Kevin Rushforth
kcr at openjdk.java.net
Wed Nov 11 16:12:00 UTC 2020
On Thu, 29 Oct 2020 15:15:22 GMT, Jonathan Vusich <github.com+31666175+JonathanVusich at openjdk.org> wrote:
> As noted in the corresponding JBS issue, `Axis` does not properly compute its preferred height when `autoRanging` is turned off. The simplest fix seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if there is not enough room for the category labels to layout horizontally. This fixes the fact that the axis labels are truncated and also ensures that the chart does not leave unused space from the layout calculations. `CategoryAxis` is already setting the `categorySpacing` property when `autoRanging` is off, so this seems to be an appropriate fix.
Can you merge in the latest `jfx/master`? That way the GitHub actions build/test will be run (although it won't run the new headful test). You also need a copyright header as noted below.
tests/system/src/test/java/test/javafx/scene/chart/ChartAxisLayoutTest.java line 1:
> 1: package test.javafx.scene.chart;
You need a standard copyright header here. See any of the other test classes for an example (should be just a single `2020,` for the year).
-------------
PR: https://git.openjdk.java.net/jfx/pull/342
More information about the openjfx-dev
mailing list