RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v2]
Jonathan Vusich
github.com+31666175+jonathanvusich at openjdk.java.net
Wed Nov 11 18:05:08 UTC 2020
> As noted in the corresponding JBS issue, `Axis` does not properly compute its preferred height when `autoRanging` is turned off. The simplest fix seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if there is not enough room for the category labels to layout horizontally. This fixes the fact that the axis labels are truncated and also ensures that the chart does not leave unused space from the layout calculations. `CategoryAxis` is already setting the `categorySpacing` property when `autoRanging` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Added copyright header
- Merge branch 'master' into jonathan/fix-chart-axis-labels
- Added fix and test
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/342/files
- new: https://git.openjdk.java.net/jfx/pull/342/files/e3eb791e..49a5e1f7
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=00-01
Stats: 1552 lines in 40 files changed: 1343 ins; 136 del; 73 mod
Patch: https://git.openjdk.java.net/jfx/pull/342.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342
PR: https://git.openjdk.java.net/jfx/pull/342
More information about the openjfx-dev
mailing list