RFR: 8256184: Openjfx build broken (Eclipse)

Nir Lisker nlisker at openjdk.java.net
Mon Nov 16 11:54:53 UTC 2020


On Mon, 16 Nov 2020 09:34:17 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> These changes look fine, but do you not get errors on the test module too? `test.javafx.scene.InitialNodesMemoryLeakTest` uses `import test.util.memory.JMemoryBuddy;`; so does `VirtualFlowMemoryLeakTest`.
>
>> 
>> 
>> These changes look fine, but do you not get errors on the test module too? `test.javafx.scene.InitialNodesMemoryLeakTest` uses `import test.util.memory.JMemoryBuddy;`; so does `VirtualFlowMemoryLeakTest`.
> 
> Good point ..  didn't notice as I don't run system tests from Eclipse. 
> 
> Hmm .. would like to keep this focused on base/controls. We might open a reminder bug to check the other moduls. What do you think?

I think that it should be fixed as part of this patch since it addresses exactly the same issue from the same cause.

-------------

PR: https://git.openjdk.java.net/jfx/pull/352


More information about the openjfx-dev mailing list