RFR: 8247576: Labeled/SkinBase: misbehavior on switching skin

Kevin Rushforth kcr at openjdk.java.net
Thu Nov 19 13:38:02 UTC 2020


On Thu, 19 Nov 2020 13:11:05 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Cleanup of LabeledSkinBase to allow for switching skins
>> 
>> - removed null check in listener on graphic's layoutBounds
>> - added removal of listener in dispose
>
> hmm .. failing windows build, why?

Not sure why it failed, but it's definitely not anything related to your change. I'll take a look at it, but in the mean time reviewers of this PR can ignore the failure.

-------------

PR: https://git.openjdk.java.net/jfx/pull/355


More information about the openjfx-dev mailing list