RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]

Jose Pereda jpereda at openjdk.java.net
Fri Nov 20 11:30:19 UTC 2020


On Thu, 19 Nov 2020 02:12:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use assertTrue instead of try-catch
>
> tests/system/src/test/java/test/javafx/scene/UIRenderSceneTest.java line 83:
> 
>> 81:         new Thread(() -> Application.launch(TestApp.class, (String[])null)).start();
>> 82:         try {
>> 83:             if (!startupLatch.await(15, TimeUnit.SECONDS)) {
> 
> If you add `throws Exception` to this method you can get rid of the try/catch and just do:
> 
>     assertTrue("Timeout waiting for FX runtime to start",
>         startupLatch.await(15, TimeUnit.SECONDS));
> 
> (this is the pattern we use for most of our newer tests)

Okay, thanks for the hint, I've just modified it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/351


More information about the openjfx-dev mailing list