RFR: 8256184: Openjfx build broken (Eclipse)

Nir Lisker nlisker at openjdk.java.net
Fri Nov 20 15:29:01 UTC 2020


On Thu, 12 Nov 2020 13:50:41 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Issue was broken build in Eclipse after fix of [JDK-8244297](https://bugs.openjdk.java.net/browse/JDK-8244297): 
>> 
>> - the new memory test class requires jdk.management/java.management
>> - users of the test class (in controls) need access to its package
>> 
>> Changed .classpath files in base and controls to fix this.
>
> The change looks reasonable to me, but since I don't use Eclipse it would be better for someone who does to review.
> @nlisker can you review this?

Yes, but that's a problem of no reviewers. If I submit it myself then there will also be no one to review. @kevinrushforth What do we do? I think that previously when I updated the Eclipse files, there's wasn't a thorough review.

-------------

PR: https://git.openjdk.java.net/jfx/pull/352


More information about the openjfx-dev mailing list