RFR: 8256184: Openjfx build broken (Eclipse)

Jeanette Winzenburg fastegal at openjdk.java.net
Fri Nov 20 16:42:59 UTC 2020


On Fri, 20 Nov 2020 16:22:32 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> 
> 
> I don't mind either way. If we want to proceed, I'm OK with either of:
> 
>     1. Accept the PR as-is and file a follow-up issue
> 
>     2. Add the change proposed by @nlisker and list him as a co-contributor (in which case he can still review it).

my preference would be 2 - would be as complete as required right now (and Nir sees it's working :). 

Still would need a follow-up issue to modify the .classpath of the other modules, to enable them to make use of the memory leak test. Might happen at the time they actually start using it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/352


More information about the openjfx-dev mailing list