RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v2]

Kevin Rushforth kcr at openjdk.java.net
Tue Nov 24 22:23:56 UTC 2020


On Wed, 11 Nov 2020 16:08:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jonathan Vusich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Added copyright header
>>  - Merge branch 'master' into jonathan/fix-chart-axis-labels
>>  - Added fix and test
>
> Can you merge in the latest `jfx/master`? That way the GitHub actions build/test will be run (although it won't run the new headful test). You also need a copyright header as noted below.

While this does fix the specific problem, it introduces a new one. If the labels are initially too big, but after resizing the window would now fit, it does not recompute the orientation. This means that you are left with labels that are rotated even when they don't need to be.

-------------

PR: https://git.openjdk.java.net/jfx/pull/342


More information about the openjfx-dev mailing list