RFR: 8254049: Update WebView to public suffix list 2020-04-24 [v3]

Kevin Rushforth kcr at openjdk.java.net
Wed Nov 25 14:11:02 UTC 2020


On Wed, 25 Nov 2020 07:09:09 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:

>> We should use the public_suffix_list.dat file in the JDK instead. Reading the public_suffix_list.dat file is modified to be similar to [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java). If the file is not present, `isPublicSuffix()` returns `false`, which is similar to how WebKit ignores the public suffix check when it is disabled.
>> 
>> Test: Run PublicSuffixesTest.java
>
> Arun Joseph has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Create pslFile variable

modules/javafx.web/src/main/java/com/sun/webkit/network/PublicSuffixes.java line 76:

> 74:      */
> 75:     private static final File pslFile = new File(
> 76:         System.getProperty("java.home"), "lib/security/public_suffix_list.dat");

I think this needs to be in a doPrivileged block. The rest looks good.

-------------

PR: https://git.openjdk.java.net/jfx/pull/324


More information about the openjfx-dev mailing list