RFR: 8090110: Very bad TextArea of performance in a language environment that uses the Chinese character (KANJI)

[Jeanette Winzenburg]

On Tue, 29 Sep 2020 15:29:48 GMT, yosbits <github.com+7517141+yososs at openjdk.org> wrote:

> 
> 
> I understand that some people want support for the **new features** of Skin Swiching.

Assuming that you are joking ;) Just in case you are not and for the record:

    skinnable.setSkin(skin)
    skin.dispose()

are public api without any notion of being optional - making the implementation of TextAreaSkin misbehaving big style.

That said: verified that the fix improves performance of the example immensely. So I think it should be integrated
asap, ignoring the big heap of mess already there.

Nevertheless, it should

- be implemented in a way to not add to the pile of dirt: instead of adding the changeListeners manually, add them via
  skin api (which will remove them automatically in dispose). That's possible if they are added once in the life-time of
  the skin, which seems to be the case, or not?
- add tests:
      - unit tests to ensure that changing properties that effect the clip actually are adjusting it
      - system? test to verify the performance gain

-------------

PR: https://git.openjdk.java.net/jfx/pull/307