RFR: 8253634: TreeCell/Skin: misbehavior on switching skin

Kevin Rushforth kcr at openjdk.java.net
Fri Oct 2 15:41:35 UTC 2020


On Fri, 25 Sep 2020 11:10:20 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> TreeCellSkin installs listeners to the TreeView/fixedCellSize that introduce a memory leak, NPE on replacing the
> treeView and incorrect update of internal state.
> Fixed by removing the listeners (and the internal state had been copied from treeView on change) and access of listView
> state when needed.
> Added tests that failed before and pass after the fix, plus a sanity test to guarantee same (correct) behavior
> before/after.
> Issue and fix is basically the same as for ListCellSkin [JDK-8246745](https://bugs.openjdk.java.net/browse/JDK-8246745)

@arapte I think a single reviewer should be sufficient, but if you think it needs a second reviewer, go ahead and
indicate that.

-------------

PR: https://git.openjdk.java.net/jfx/pull/309


More information about the openjfx-dev mailing list