RFR: 8244297: memory leak test utility [v4]

Florian Kirmaier fkirmaier at openjdk.java.net
Sat Oct 3 16:21:40 UTC 2020


On Thu, 1 Oct 2020 17:29:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Thanks, we'll review it now.
>> 
>> Btw, we don't plan to hook up Travis, but instead will be looking at GitHub actions now that the `jdk` project is using
>> them successfully.
>
> It looks like you are missing an import statement in one of the tests:
> 
>> Task :systemTests:compileTestJava
> ...\jfx\tests\system\src\test\java\test\javafx\scene\InitialNodesMemoryLeakTest.java:88: error: cannot find symbol
>         JMemoryBuddy.assertCollectable("groupWRef");
>         ^
>   symbol:   variable JMemoryBuddy
>   location: class InitialNodesMemoryLeakTest
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 1 error
> 
> You can run the following locally on your system once you have fixed this to verify that there are no others.
> 
> gradle --continue -PFULL_TEST=true test

`./gradlew --continue -PFULL_TEST=true test` Seems to be very unstable on my machine (Mac). It produces various errors,
which are not related to my changes, which makes it basically useless in my environment.

I've checked the 4 changed tests with the following commands:
`./gradlew --continue -PFULL_TEST=true controls:test`
` ./gradlew --continue -PFULL_TEST=true systemTest:test --tests "*VirtualFlowMemoryLeakTest*"`
`./gradlew --continue -PFULL_TEST=true systemTest:test --tests "*ProgressIndicatorLeakTest*"`
`./gradlew --continue -PFULL_TEST=true systemTest:test --tests "*InitialNode*" `
They all compile now and are green.

-------------

PR: https://git.openjdk.java.net/jfx/pull/204


More information about the openjfx-dev mailing list