RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper [v4]

yosbits github.com+7517141+yososs at openjdk.java.net
Sun Oct 4 05:50:35 UTC 2020


On Fri, 2 Oct 2020 16:29:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The fix looks good to me. I left a few comments on the test, but it looks like a great start.
>
> One meta-comment:
> 
>>  @yososs yososs force-pushed the yososs:8253086_Optimization_of_removeAll_and_retainAll_of_ObservableListWrapper branch
>>  ...
> 
> As indicated in the [CONTRIBUTING
> guidelines](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#submitting-your-changes-via-a-pull-request),
> please don't force-push to your branch.

I understand that your testing requirements are higher than when this tested class was implemented.
The fix will be pushed in the next few days.

I hope I can check the coding style (including spaces) with the gradle task before git push.
Let me know if there is a way to make jcheck work on my device.

-------------

PR: https://git.openjdk.java.net/jfx/pull/305


More information about the openjfx-dev mailing list