RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper [v4]

[Eric Bresie]

On Wed, 7 Oct 2020 12:06:09 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> I'm preparing a change that won't break compatibility, so stay tuned.
>> The test seems to need to be added.
>
>> 
>> 
>> I'm preparing a change that won't break compatibility, so stay tuned.
>> The test seems to need to be added.
> 
> sounds good :) Note, that I'm working on [JDK-8254040](https://bugs.openjdk.java.net/browse/JDK-8254040) which will add
> regression tests that your change will have to pass (turned out that f.i. FilteredList also relies on the two-pass
> approach).  Until you are done, you might consider changing the state of this to Draft.

Hopefully not looking in the wrong version but:
(1) When dealing with BitSets previously, maybe this was by design butI didn’t see any usage of BitSet’s
“clear(<index>)” to remove items from the BitSet.  Although given move to remove it may be moot now. (2) If no longer
using the BitSet, may want to remove the import for this (3) In context, usage of HashSet was suggested.  I don’t
believe HashSet is thread safe.  If using it, may want to consider ConcurrentHashSet.  Although not sure if this is
more efficient either.

-------------

PR: https://git.openjdk.java.net/jfx/pull/305