RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper [v5]
yosbits
github.com+7517141+yososs at openjdk.java.net
Thu Oct 8 06:52:56 UTC 2020
> https://bugs.openjdk.java.net/browse/JDK-8253086
>
> ObservableListWrapper.java
> * public boolean removeAll(Collection<?> c)
> * public boolean retainAll(Collection<?> c)
>
> These two methods use BitSet, but it doesn't make sense.
> By rewriting to the equivalent behavior that does not use BitSet, it is possible to reduce the CPU load in a wide range
> of use cases.
> The test is done with the following command.
>
> * gradle base: test
> * gradle controls: test
yosbits has updated the pull request incrementally with one additional commit since the last revision:
8253086: Optimization of removeAll and retainAll of ObservableListWrapper
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/305/files
- new: https://git.openjdk.java.net/jfx/pull/305/files/8b319c6d..93aeda88
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=305&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=305&range=03-04
Stats: 146 lines in 3 files changed: 96 ins; 9 del; 41 mod
Patch: https://git.openjdk.java.net/jfx/pull/305.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/305/head:pull/305
PR: https://git.openjdk.java.net/jfx/pull/305
More information about the openjfx-dev
mailing list