RFR: 8217472: Add attenuation for PointLight [v15]

Nir Lisker nlisker at openjdk.java.net
Fri Oct 9 14:59:17 UTC 2020


On Fri, 9 Oct 2020 12:34:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java line 135:
> 
>> 133:     @AfterClass
>> 134:     public static void teardown() {
>> 135:         Platform.runLater(() -> {
> 
> I forgot to mention that the `@AfterClass` method is still run even if the call to `assumeTrue` in the `@BeforeClass`
> method causes the test to be skipped. You will need to repeat the check (or set a flag in `initFX` and check that flag)
> here and skip the cleanup if the initialization was skipped (using an `if` check, not repeating the `assumeTrue`).
> Otherwise the exception that is thrown here will cause the test to fail.  You can test this by forcing the SW pipeline.
> I did it like this:  _JAVA_OPTIONS="-Dprism.order=sw" gradle --info -PFULL_TEST=true :systemTests:test --tests
> PointLightAttenuationTest

The test fails even with this addition. I found that I need to use `@Before` to run the check, and then I don't need
the ones in `@BeforeClass` and `@AfterClass`, should I keep those?

-------------

PR: https://git.openjdk.java.net/jfx/pull/43


More information about the openjfx-dev mailing list