RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

Arun Joseph ajoseph at openjdk.java.net
Mon Oct 12 13:54:09 UTC 2020


On Mon, 12 Oct 2020 13:42:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Instead of negation, it should have been at the opposite positions. I have fixed this in the latest commit. The arg
>> list order for
>> [`concatenate`](https://github.com/openjdk/jfx/blob/a56ba63bef9b33c4ad5cc9e05ae5bdb0ee480a3f/modules/javafx.graphics/src/main/java/com/sun/javafx/geom/transform/AffineBase.java#L2849)
>> is different compared to the constructor of Affine2D.
>
> With your latest change, the call looks like what I would expect now. I suspect a shear transform would have been
> broken before this last fix, but I didn't try it.

Yes, shear transforms were broken before this commit. Now, all transforms works as expected.

-------------

PR: https://git.openjdk.java.net/jfx/pull/190


More information about the openjfx-dev mailing list