RFR: 8254605: repaint on Android broken [v2]
Florian Kirmaier
fkirmaier at openjdk.java.net
Tue Oct 20 09:27:08 UTC 2020
On Mon, 19 Oct 2020 18:26:43 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Marked as reviewed by kcr (Lead).
>
> Reverting #153 seems right, I don't have any specific comments. Please go ahead and merge the change.
@johanvos @jperedadnr
A unit-test would be great, otherwise, it would be very hard to fix the memory-leak again.
Is this reproducible outside of the android setup, when calling repaintFromNative explicitly?
Imo the importance of the memoryleak-fix is a bit underestimated because it's a requirement to test for correct
memory-behavior. The only reason reverting it doesn't break all kinds of tests is that no one is testing for memory
leaks.
-------------
PR: https://git.openjdk.java.net/jfx/pull/322
More information about the openjfx-dev
mailing list