RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_* [v2]
Ajit Ghaisas
aghaisas at openjdk.java.net
Wed Oct 21 11:54:24 UTC 2020
> It is a test cleanup work.
>
> Issue :
> Many unit tests in javafx.controls module have incorrect naming that use text "impl_" in names and comments.
> The test code correctly avoids using impl_* methods (as they were removed in JDK 9), but test names still have "impl_" in them.
>
> Fix :
> These tests are renamed by replacing impl_* with appropriate css method.
Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
JDK-8255002 - review fixes
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/326/files
- new: https://git.openjdk.java.net/jfx/pull/326/files/18c35fa9..9e6849b1
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=326&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=326&range=00-01
Stats: 17 lines in 3 files changed: 0 ins; 15 del; 2 mod
Patch: https://git.openjdk.java.net/jfx/pull/326.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/326/head:pull/326
PR: https://git.openjdk.java.net/jfx/pull/326
More information about the openjfx-dev
mailing list