RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_* [v2]

Ambarish Rapte arapte at openjdk.java.net
Thu Oct 22 06:26:09 UTC 2020


On Wed, 21 Oct 2020 11:54:24 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> It is a test cleanup work.
>> 
>> Issue :
>> Many unit tests in javafx.controls module have incorrect naming that use text "impl_" in names and comments.
>> The test code correctly avoids using impl_* methods (as they were removed in JDK 9), but test names still have "impl_" in them.
>> 
>> Fix :
>> These tests are renamed by replacing impl_* with appropriate css method.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8255002 - review fixes

Marked as reviewed by arapte (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/326


More information about the openjfx-dev mailing list