RFR: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code

[Kevin Rushforth]

On Thu, 22 Oct 2020 12:13:11 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> Some of the ignored unit tests in javafx.controls module pass with latest code.
> This bug is to address -
> - removal of ignored tag
> - fixing the test if fix is minor

It works for me on Windows. Have you run it on more than one platform?

I left one suggestion for you regarding the constants in TableColumnShim.

modules/javafx.controls/src/shims/java/javafx/scene/control/TableColumnShim.java line 34:

> 32: 
> 33:     // NOTE: These constants are direct copy of TableColumnBase
> 34:     public static final double DEFAULT_WIDTH = 80.0F;

Can you define these to reference those constants rather than copying them, like this?

     public static final double DEFAULT_WIDTH = TableColumnBase.DEFAULT_WIDTH ;

If so, you can remove the comments about needing to keep them in sync.

modules/javafx.controls/src/main/java/javafx/scene/control/TableColumnBase.java line 121:

> 119: 
> 120:     // NOTE: If these numbers change, update the copy of this value in
> 121:     // TableColumnHeader and in TableColumnShim

I think you can revert this change.

-------------

PR: https://git.openjdk.java.net/jfx/pull/331